Fix the concurrency label for the add-changelog-snippet workflow
#42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwodder
added
patch
github-actions
bot
removed
the
CHANGELOG-missing
|
PR released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the workflow triggers on
pull_request_targetrather thanpull_request,github.ref_namewill be the name of the base branch (i.e., "master", "maint", or "main"), which means that, if multiple PRs with a CHANGELOG-missing label are opened in quick succession, all but one of theadd-changelog-snippetworkflows for the PRs as a group will be cancelled, which is not want we want. We want the cancellation to only kick in if multiple runs are started on the same PR at once (which happens if a PR is created with multiple labels), so the concurrency label should use a string that is specific to the head (source) of the PRs.