BI-5376: Add db_name validation #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
br0vk1n-ia
force-pushed
the
add_db_name_validation
branch
from
e80b1bf to
280627c
Compare
| bi_headers: Optional[dict[str, str]], | ||
| connection_params: dict, | ||
| ) -> None: | ||
| if not self.uses_classic_sql_connection_schema: |
There was a problem hiding this comment.
Maybe let's skip the test on this sort of condition?
if "db_name" not in connection_params:
pytest.skip("No db_name field in schema")This way we won't need to bother about what schema each connector uses and can throw away the uses_classic_sql_connection_schema flag
KonstantAnxiety
approved these changes
Jun 25, 2024
|
all tests passed |
KonstantAnxiety
added
component/connectors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.