fix(connectors): BI-5777 handle google api errors & bad creds error in BQ connector #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KonstantAnxiety
changed the title
KonstantAnxiety
added
component/connectors
ForrestGump
approved these changes
Sep 6, 2024
KonstantAnxiety
added
the
ci-approved
|
Something weird happened to CI in this PR, its report didn't want to stick to it, re-labeling seemingly helped, all test passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also semi-fix test table setup (user type map, sqlalchemy types)
Also, there are a bunch of failing tests (e.g.
TestBigQueryDataCacheand most ofapi/), that could never be green because of the issues above and thisdatalens-backend/lib/dl_api_lib_testing/dl_api_lib_testing/helpers/data_source.py
Line 8 in d467d40