Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Response to Feature Request: Adding error subscripts option #216

Merged
merged 2 commits into from
Mar 14, 2022

Conversation

q-w-a
Copy link
Contributor

@q-w-a q-w-a commented Mar 11, 2022

Greetings,

This pull request is designed to implement the functionality discussed in Issue #145.

@datalorax
Copy link
Owner

Thanks! It looks like this isn't passing R CMD Check. Can you possibly do the following? I'd be happy to merge in after that.

  • fix the issues with R CMD Check
  • build tests for this new feature
  • update the NEWS to reflect this new feature
  • add yourself as a contributor in the DESCRIPTION

- build tests
- fix negative sign handling
- update news
- added myself as a contributor in the DESCRIPTION file
@q-w-a
Copy link
Contributor Author

q-w-a commented Mar 12, 2022

Thank you! I addressed the issues you mentioned. Let me know if there is anything else I should do.

@datalorax
Copy link
Owner

Great! Thank you so much for your contribution! This is a great addition!

@datalorax datalorax merged commit 6e71b47 into datalorax:master Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants