General code refresh #132
Merged
General code refresh #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e need a major version bump
…ts (though we'll still build for that target)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PeriodicBatchingSinkAPIOne behavioral change is that any level control from the Seq server will now be applied before the event is enqueued; previously, the check was made when filling a batch. This only affects sinks that don't control the root logger - in that case the events never reach the queue either way.
This bumps the major package version because new APIs from Serilog 2.9 are used; a follow-up PR will include some further breaking changes that will help keep this project in good shape, making the reduced compatibility more worthwhile.