Add independent expenditure scraper #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antidipyramid
commented
Sep 12, 2024
|
|
||
|
|
||
| class IndependentExpenditureScraper(scrapelib.Scraper): | ||
| election_years = ("2021", "2022", "2023", "2024") |
There was a problem hiding this comment.
I used the same election years as in scrape_offices.py.
hancush
reviewed
Sep 13, 2024
There was a problem hiding this comment.
This looks legit to me, @antidipyramid! How many expenditure records does it create, and how does that compare to the number of expenditures in the portal? If it's close, can you go ahead and send the data file to Marjorie and ask her for feedback on the format, and ask whether she notices any records or important data points missing?
|
@hancush We didn't get any comments/questions-- seems like Marjorie is OK with the format. |
|
@antidipyramid I'm good for this to come in. You can address any data issues Marjorie reports, separately. |
hancush
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
See title.
Closes #27
Testing instructions
Run
python -m scrapers.financial_disclosure.scrape_independent_expenditures