-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pr/dessygil/40 #47
Pr/dessygil/40 #47
Conversation
…els that have an encoder. modelcard produced and sentencepiece added to the dependencies
…ove sentencepiece to the optional dependencies in pyproject.toml and env.yml
Fix #43 from molfeat.trans.pretrained.hf_transformers import PretrainedHFTransformer
import datamol as dm
smiles = dm.freesolv()["smiles"]
transformer = PretrainedHFTransformer("ChemBERTa-77M-MLM", notation="smiles", precompute_cache=True)
output = PretrainedHFTransformer.batch_transform(transformer, smiles, batch_size=128, concatenate=False)
len(transformer.precompute_cache) # should be len(smiles). Pretrained models should now work better with |
I have also documented missing featurizers now: from molfeat.store import ModelStore
store = ModelStore()
_, m = store.load("mordred")
print(m.usage())
ping @cwognum |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not blocking, but any idea on how we could present this in a more aesthetically pleasing way? Maybe have them on the Molfeat website?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I will ping @mercuryseries for that.
Checklist:
news
entry.news/TEMPLATE.rst
tonews/my-feature-or-branch.rst
) and edit it.xref #40 pinging @dessygil