Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in canonical due to for loop on set #16

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Conversation

maclandrol
Copy link
Member

Changelogs


Checklist:

  • Add tests to cover the fixed bug(s) or the new introduced feature(s) (if appropriate).
  • Update the API documentation if a new function is added, or an existing one is deleted. Eventually consider making a new tutorial for new features.
  • Write concise and explanatory changelogs below.
  • If possible, assign one of the following labels to the PR: feature, fix or test (or ask a maintainer to do it for you).

This PR fixes the #15 for canonical SAFE strings, which was caused by failure to account for order in sets.

@maclandrol maclandrol added the fix Fix a bug label Nov 7, 2023
@maclandrol maclandrol requested a review from hadim November 7, 2023 06:24
@kjappelbaum
Copy link
Contributor

can confirm that this fixes the issue! Thanks for the fast turnaround!

@hadim hadim merged commit e1e2cbd into main Nov 8, 2023
3 checks passed
@hadim hadim deleted the fix/canonical-safe branch November 8, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fix a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

output is not deterministic (?)
3 participants