-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for patterns in scaffold decoration #59
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @maclandrol
The generation process is the constrained generation based on scaffold with pattern, followed by fragment extension.
Could you also add a few bullet points docstrings on the generation logic for both classes to make the explanation easier to understand for others?
Thanks, I will address those comments. |
All fixed now. Thanks @zhu0619 |
Changelogs
Checklist:
feature
,fix
ortest
(or ask a maintainer to do it for you).In this PR, scaffold decoration with SAFE is extended to support molecular patterns (SMARTS). Note that the full specification of SMARTS is not supported in this implementation due to various limitations with the tokenizer and how SMARTS patterns are matched with the tokens for constrained-sampling.