-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev: Make command to create new OAuth #35
Conversation
Why do we have this as callbake_url instead of callback_url?
Is it intentional? |
No just typo🫣. |
Ok, fine. |
If you can, a new PR is the best choice. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please run composer cs-fix
.
Sent a PR #36 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So far so good, please continue!
About the languages files, will that still be necessary? I ask because the number of files will definitely increase as more developers start using the library, and it may become very difficult to manage. What do you think? |
Maybe it would be good to display the message and explain it. |
How do you suggest? |
Don't forget to translate the language strings. See https://github.com/datamweb/shield-oauth/blob/develop/docs/add_other_oauth.md#add-lang-file for details. I'm not sure about this, the final decision is yours. |
Personally, I don't think it is ideal to automatically generate the language files for all languages. I feel it's best done manually, per PR, just like shield. |
Well, I run the command for the first time 🤩. Delete file app/Config/ShieldOAuthConfig.php. I think if file ShieldOAuthConfig.php doesn't exist, app\Libraries\ShieldOAuth\YahooOAuth.php shouldn't be created. |
Yes, you are correct! |
And we forgot the documents 😂. |
I think I finally saw the need to automatically create the default language file, and I've included it in this commit. Please review and let me know what you think. |
Hi @datamweb, Care to check the updates? |
@sammyskills Hi, sorry for the delay, I'm a bit busy, I'll try to check by the weekend. Thank you! |
@sammyskills Thank you for your efforts. |
Hi @datamweb, I totally understand.
I tested before pushing the commit. But please check when you are less busy. |
This PR helps to quickly create and update the necessary file(s) to build a new OAuth.
Fixes #3