-
Notifications
You must be signed in to change notification settings - Fork 65
DataSatOslo - Added possibility to set top and bottom margin for spon… #333
Conversation
…sor logos. Added 2 new sponsors
Hey man! I see that you changed the way the site generator works... |
The logic looks fine as there is a default and we also have an additional sponsor benefits from Atlanta, which looks good DataSaturdays/_layouts/post.html Line 118 in b92fc6b
https://datasaturdays.com/2022-10-01-datasaturday0028/#sponsors It would be good to get those added into the GH Action and issue as well |
So I guess we can merge it? |
That is correct. I have made quite a few changes in order to get the type event page and info we wanted to present. These are the changes I have made over the course of a few months:
I think that was it. As @SQLDBAWithABeard mentions the new attributes for margins for sponsor logos have a default setting and that also applies for all the other functionality I have added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve this change with all the power of greyskull
I love all of this @RuneORakeie - be awesome to incorporate all of this and the sponsor thing I whipped up for Atlanta and make that all the default |
Yes @SQLDBAWithABeard we should. Both for the template and also updating the docs explaining the purpose of them. I addition I would also like to incorporate Daniel Hutmacher solution for the raffle. He built one for DataSat Stockholm. |
…sor logos. Added 2 new sponsors