Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dbatools-buildref-index.json SQL2022 CU15 #9476

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

MikeyBronowski
Copy link
Contributor

Type of Change

  • Bug fix (non-breaking change, fixes # )
  • New feature (non-breaking change, adds functionality, fixes # )
  • Breaking change (affects multiple commands or functionality, fixes # )
  • Ran manual Pester test and has passed (.\tests\manual.pester.ps1)
  • Adding code coverage to existing functionality
  • Pester test is included
  • If new file reference added for test, has is been added to github.com/dataplat/appveyor-lab ?
  • Unit test is included
  • Documentation
  • Build system

Purpose

KB5041321 - Cumulative Update 15 for SQL Server 2022

Approach

Commands to test

Screenshots

Learning

@MikeyBronowski
Copy link
Contributor Author

MikeyBronowski commented Sep 25, 2024

Lol, time zones :)

Describe : Get-DbaBuild Unit Test
Context  : Validate LastUpdated property
Name     : It LastUpdated is not in the future
Result   : Failed
Message  : Expected the actual value to be less than 2024-09-25T23:22:51.2771146+00:00, but got 2024-09-26T00:00:00.0000000.

@niphlod
Copy link
Contributor

niphlod commented Sep 26, 2024

@potatoqualitee can you merge this ? the community is always eager to get updates ASAP. given we linked the public data to the file present in development, at least that step needs to happen, a full release of the module is not needed.

@niphlod
Copy link
Contributor

niphlod commented Sep 30, 2024

BTW @potatoqualitee I think we need to re-view the update process (https://github.com/dataplat/dataplat.github.io/blob/master/.github/workflows/updateassets.yml) as waiting for a PR to be merged in in the last few months is resulting in several days of "staleness" on the index

@wsmelton
Copy link
Member

wsmelton commented Oct 1, 2024

We can likely get a workflow created to auto merge these

@wsmelton wsmelton merged commit 49f7514 into dataplat:development Oct 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants