Get-DbaDbMailServer: Fix e-mail account names if more than one account exists

[potatoqualitee]

Redo of this PR with smaller git repo: #9497

Fix an error that results in all account names matching the first account instead of corresponding to real account names.

Type of Change

• Bug fix (non-breaking change, fixes Get-DbaDbMailServer shows incorrect e-mail account names if more than one account exists. #9496 )

Purpose

Fix an error that results in all account names matching the first account instead of corresponding to real account names.

Approach

Each corresponding account name is used instead of the only using first account name for all results.

Note: I changed the coding slightly, as it seemed that -Force would keep overwriting the account names. So now it's an array. Please let me know if I need to take a different approach.

[andreasjordan]

I think your solution has kind of the same problem as the old code: There could be different mailservers on different instances all handled in this code. The Account property needs to be from the specific mailserver, that's why the foreach is needed.

$servers | ForEach-Object {
                       $_ | Add-Member -Force -MemberType NoteProperty -Name Account -value $_.Parent.Name
                    }

[potatoqualitee]

but won't -Force just keep overwriting it and you only get the last one? with mine, an array is returned? i suppose i should test this but i got a lot to do 😅

[andreasjordan]

No, -Force is just for the case that the same SMO runs again through this command. In the foreach, every $server is only updated once with the correct value for this $server.

[potatoqualitee]

ty!

[andreasjordan]

Now you have merged your version without the foreach. That will not solve the problem.