Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please do not leak token when error occurs in /ui dashboard #688

Open
Bluscream opened this issue Feb 10, 2024 · 1 comment
Open

Please do not leak token when error occurs in /ui dashboard #688

Bluscream opened this issue Feb 10, 2024 · 1 comment
Assignees

Comments

@Bluscream
Copy link

Bluscream commented Feb 10, 2024

I know this dashboard is not supposed to be shown on stream but sometimes it happens that people accidentally tab into their dashboard's overview and in this case it would immediately reveal their token to everyone without even being in some kind of settings subpage.

Maybe make it replace the token with token=<REDACTED> or similar, or just remove it from the error message

@ioppermann ioppermann self-assigned this Feb 16, 2024
@ioppermann
Copy link
Member

Thanks for pointing this out. We will have look at it.

ioppermann added a commit to datarhei/restreamer-ui that referenced this issue Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants