-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optional "client_name" additional property in clients to specialize user-agent? #173
Comments
A design decision is in order here. The context is, a future LangChain will use a future astrapy and set this optional "client name", which goes all the way to the user agent. LangChain's classes (as many other similar plugins) accept both the credentials to create their
Now,
So, even if going with
Choosing param for AstraDB and instance property for AstraDBCollection is ... ugly and asymmetrical. |
Do we have enough information to make a decision on the design options shared above? |
Well, this is mostly an internal issue of maintainability/flexibility, with little exposure to code using astrapy (such as the LangChain plugin) and virtually zero to end user, so we can go with what looks like a least-effort satisfactory choice and adjust later (though hopefully not). |
Thank you for this information, do we have an idea for when this can be prioritized for implementation? I'm coordinating the downstream changes needed to surface in BQ and MixPanel, and the upstream integrations (ex. Llamaindex, Langchain) |
* replaced the ApiRequestHandler classes with functions * add user-agent function and get rid of all the default params in utils/api stack * caller_name/version infrastructure ready to use by ops/db * add headers test dependency and sample test for user-agent --------- Co-authored-by: Eric Hare <ericrhare@gmail.com>
to be prepended to user-agent if provided (with separating slash).
Very back-compatible.
The text was updated successfully, but these errors were encountered: