enhanced copy methods for astrapy objects #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fantastic @hemidactylus . i've been out as you know and seeing this made me very happy :D and as always a very thorough test. LGTM and thank you for taking care of this! |
erichare
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the possibility to supply override to any parameter during calls to the
copy()method (for AstraDB, AstraDBCollection, +the two async counterparts, and AstraDBOps).Building on this, care is taken that the constructor for AstraDBCollection (+async) does not silently discard some of the parameters when the
astra_dbis passed (namely namespace, token and endpoint), rather treats them as overrides on the passed astra_db.Full testing is also added.