Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Ingress API Version #140

Closed
michaeljmarshall opened this issue Jan 28, 2022 · 3 comments
Closed

Update Ingress API Version #140

michaeljmarshall opened this issue Jan 28, 2022 · 3 comments

Comments

@michaeljmarshall
Copy link
Member

Sample warning when using the Ingress for PulsarSQL:

W0128 16:06:08.502415 22507 warnings.go:70] extensions/v1beta1 Ingress is deprecated in v1.14+, unavailable in v1.22+; use networking.k8s.io/v1 Ingress
@michaeljmarshall michaeljmarshall mentioned this issue Jan 28, 2022
Merged
@michaeljmarshall
Copy link
Member Author

Here is the relevant documentation https://kubernetes.io/docs/reference/using-api/deprecation-guide/#ingress-v122. Since we still support 1.19, we'll need to branch based on the k8s version.

@lhotari
Copy link
Contributor

lhotari commented Feb 9, 2022 •
edited
Loading

the change in Apache Pulsar Helm chart: apache/pulsar-helm-chart@83bb8bd6 . It's more than just changing the apiVersion. it looks like the schema has changed slightly.

@MMirelli MMirelli mentioned this issue Mar 8, 2022
Merged
@lhotari
Copy link
Contributor

lhotari commented Mar 22, 2022

resolved by #154

@lhotari lhotari closed this as completed Mar 22, 2022
pgier pushed a commit to pgier/datastax-pulsar-helm-chart that referenced this issue Jul 13, 2022
@toneill818
Add Support for imagePullSecrets (datastax#140)
19d6ce6 
Fixes datastax#125

### Motivation

The default images in the values.yaml are in docker hub. This PR allows us to provide image pull secrets for the containers which will allow us to get around Docker Hub's rate limiting if the nodes are not logged into Docker Hub.

### Modifications

Added a new template to generate `imagePullSecrets`, and included them in the deployments and statefulsets. This will only add them if they are specified under `images.imagePullSecrets`

### Verifying this change

- [] Make sure that the change passes the CI checks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lhotari @michaeljmarshall