Make intra cluster TLS work #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeljmarshall
force-pushed
the
fix-intra-cluster-tls-configuration
branch
from
155c0bb to
10598e2
Compare
This was referenced Apr 26, 2022
michaeljmarshall
added a commit
that referenced
this pull request
Apr 26, 2022
These values were accidentally added in #172. They are not used and were never used, so we can safely remove them.
pgier
pushed a commit
to pgier/datastax-pulsar-helm-chart
that referenced
this pull request
Jul 13, 2022
… the port name (datastax#172) Fixes datastax#158 (This is the second PR - see also apache/pulsar-helm-chart#162) ### Motivation * All non-standard port-names need a proper protocol prefix to support Istio https://istio.io/latest/docs/ops/configuration/traffic-management/protocol-selection/#explicit-protocol-selection ### Modifications Add the prefix value before `bookie`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In order to better support a zero-trust deployment, make it possible to configure TLS for all connections.