Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpsCenter 6.8.32 Release #125

Merged
merged 4 commits into from
Jan 12, 2024
Merged

OpsCenter 6.8.32 Release #125

merged 4 commits into from
Jan 12, 2024

Conversation

vimal-ds
Copy link
Contributor


Release Notes Automation

If you name your pull-request as "Product x.y.z Release ...", after merging the
PR, a GitHub Action will automatically create a product version tag "product-x.y.z".

Supported product names are:

  • DSE
  • OpsCenter
  • Studio
  • Luna Streaming

Version supports 3 sets or 4 sets of digits.

@vimal-ds vimal-ds requested a review from orion104 January 11, 2024 10:24
## Backup Service
* Add the missing key to details-sstables so opsc won't raise an incorrect error as backup failure (OPSC-17423)
* Improved test cases to add more value to fetch event store. (OPSC-17419)
* Clean stale backup/snapshot data when previous cleanup or the job failed in Sync Retry. (OPSC-17186)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Clean stale backup/snapshot data when previous cleanup or the job failed in Sync Retry. (OPSC-17186)
* Clean-up stale backup/snapshot data when previous cleanup job failed or the job failed during Sync Retry step. (OPSC-17186)

* Added Commitlog backups cache refresh button in commitlogs dialog. (OPSC-17403)

## Core
* Publish failover and missing heartbeat after heartbeat_reply_period through event services (OPSC-17212)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Publish failover and missing heartbeat after heartbeat_reply_period through event services (OPSC-17212)
* Publish failover and missing heartbeat after `heartbeat_reply_period` through event services (OPSC-17212)

* Scripts for load testing stomp service (OPSC-17443)

## UI
* Limit session to User Agent and IP (OPSC-17278)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

limit to how much?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

single session

@vimal-ds vimal-ds requested a review from msmygit January 11, 2024 13:44
* Add the missing key to details-sstables so opsc won't raise an incorrect error as backup failure (OPSC-17423)
* Improved test cases to add more value to fetch event store. (OPSC-17419)
* Clean-up stale backup/snapshot data when previous cleanup job failed or the job failed during Sync Retry step. (OPSC-17186)
* Fixed bugs when running a backup using {{allow_one_failure}} when one agent is down. (OPSC-17421)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Fixed bugs when running a backup using {{allow_one_failure}} when one agent is down. (OPSC-17421)
* Fixed bugs when running a backup using `{{allow_one_failure}}` when one agent is down. (OPSC-17421)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it's too late in the game, but shouldn't we name that field as {{allow_one_agent_failure}} instead for clarity?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@orion104 thoughts?

@vimal-ds vimal-ds requested a review from msmygit January 11, 2024 14:06
Copy link
Collaborator

@msmygit msmygit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Release notes LGTM, but I still have question on the actual implementation variable name used. See my earlier comment

Copy link
Collaborator

@orion104 orion104 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ug. I hadn't realized I've been forgetting to review the docs notes when reviewing tickets. Sorry but I had opinions about pretty much everything.

11 Jan 2024

## Backup Service
* Add the missing key to details-sstables so opsc won't raise an incorrect error as backup failure (OPSC-17423)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Resolved and error when opscenterd encounters and unexpected key when processing backup status reports from nodes."


## Backup Service
* Add the missing key to details-sstables so opsc won't raise an incorrect error as backup failure (OPSC-17423)
* Improved test cases to add more value to fetch event store. (OPSC-17419)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Resolved various errors that occurred after a backup sync was deleted."

## Backup Service
* Add the missing key to details-sstables so opsc won't raise an incorrect error as backup failure (OPSC-17423)
* Improved test cases to add more value to fetch event store. (OPSC-17419)
* Clean-up stale backup/snapshot data when previous cleanup job failed or the job failed during Sync Retry step. (OPSC-17186)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Backup clean up code will now run after a sync retry."

* Clean-up stale backup/snapshot data when previous cleanup job failed or the job failed during Sync Retry step. (OPSC-17186)
* Fixed bugs when running a backup using `{{allow_one_failure}}` when one agent is down. (OPSC-17421)

## Backup Service,UI
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this to only be under the backup service rather than trying to display it in two places.

* Publish failover and missing heartbeat after `heartbeat_reply_period` through event services (OPSC-17212)

## Core,TestEng
* Scripts for load testing stomp service (OPSC-17443)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove completely. We only need release notes for code changes that are customer facing. Tests and internal tool don't need release notes.

* Publish failover and missing heartbeat after `heartbeat_reply_period` through event services (OPSC-17212)

## Core,TestEng
* Scripts for load testing stomp service (OPSC-17443)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove completely. We only need release notes for code changes that are customer facing. Tests and internal tool don't need release notes.

* Scripts for load testing stomp service (OPSC-17443)

## UI
* Limit a session to a specific User Agent and IP address (OPSC-17278)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change user agent to be lower case.

@vimal-ds vimal-ds requested a review from orion104 January 11, 2024 16:38
@vimal-ds vimal-ds merged commit 75afdc3 into master Jan 12, 2024
@vimal-ds vimal-ds deleted the opscenter-6.8.32-release branch January 12, 2024 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants