Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPARKC-704 - spark 3.5.0 support #1363

Merged
merged 12 commits into from
Feb 2, 2024

Conversation

JackBuggins
Copy link
Contributor

@JackBuggins JackBuggins commented Aug 15, 2023

Description

Upgrades core dependencies against the spark 3.5.0 RC1.

How did the Spark Cassandra Connector Work or Not Work Before this Patch

Changes required for compatibility with API changes present in the spark 3.5.0 RC1, see

  • https://github.com/apache/spark/pull/39627,
  • https://github.com/apache/spark/pull/41928,

General Design of the patch

How the fix is accomplished, were new parameters or classes added? Why did you
pursue this particular fix?

This has been persued to aid the community in preparing a release, with a goal that we can rapidly deliver an update on the 3.5.* stream as well as potentially publish RC's of the connector in line with Sparks RC phases. This can help ease engagement of voting on spark for users of this project, by making this dependency available for them.

Provides: SPARKC-704

How Has This Been Tested?

The upgrade has been tested via unit/integration tests locally and via CI, and a limited run of external private integration tests; more validation is welcome via RC stages by other users to extend the scope. The staging repository was used to fetch Spark 3.5* release candidate builds. As this progresses from a RC state, we should seek to remove that registry from the set of resolvers for the project. This could be carried out in another branch.

Checklist:

  • I have a ticket in the OSS JIRA
  • I have performed a self-review of my own code
  • Locally all tests pass (make sure tests fail without your patch)

@JackBuggins JackBuggins marked this pull request as ready for review August 15, 2023 22:39
@JackBuggins
Copy link
Contributor Author

RC2 is out, don't anticipate any issues, but I'll bump this up and resolve conflicts soon regardless.

@JackBuggins JackBuggins changed the title SPARKC-704 - spark 3.5.0 support (Draft) SPARKC-704 - spark 3.5.0 support Sep 20, 2023
@JackBuggins
Copy link
Contributor Author

JackBuggins commented Sep 20, 2023

This pull request is now ready for review, due to publishing of spark 3.5 GA

@JackBuggins
Copy link
Contributor Author

@jtgrabowski, would you mind looking over this one?

@tobiasstadler
Copy link
Contributor

@jtgrabowski could you please have a look?

@kopens-lsb
Copy link

빨리 좀 머지해쥬셩

@s-natsubori
Copy link

why not marged & released?

@JackBuggins
Copy link
Contributor Author

@jtgrabowski Sorry to tag you twice, I noticed that recently you had reviewed another PR.

Do you think you would be in a position to conduct a review/facilitate the pre req of cutting branch-3.4 any time soon? Much appreciated if you can carve the time.

Copy link
Collaborator

@jtgrabowski jtgrabowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, please fix one typo and we are good to go :)

README.md Outdated
@@ -45,15 +45,17 @@ corresponds to the 1.6 release. The "master" branch will normally contain
development for the next connector release in progress.

Currently, the following branches are actively supported:
3.4.x ([master](https://github.com/datastax/spark-cassandra-connector/tree/master)),
3.5.x ([master](https://github.com/datastax/spark-cassandra-connector/tree/master)),
3.4.x ([b3.4](https://github.com/datastax/spark-cassandra-connector/tree/master/b3.4)),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove master here, it should be https://github.com/datastax/spark-cassandra-connector/tree/b3.4

@jtgrabowski
Copy link
Collaborator

Sorry, I think I caused a conflict by changing the README.md. Could you please rabase?

@maciejkrol-algo
Copy link

Is this pull request crucial for Spark 3.5 connecting to Cassandra db?

@jtgrabowski jtgrabowski merged commit 05ca11a into datastax:master Feb 2, 2024
6 checks passed
@jtgrabowski
Copy link
Collaborator

Thank you @JackBuggins !

@tobiasstadler
Copy link
Contributor

@jtgrabowski Could you please create a release? Thank You!

@jtgrabowski
Copy link
Collaborator

The new release will come out next week.

@tobiasstadler
Copy link
Contributor

Thank You!

@jtgrabowski
Copy link
Collaborator

The release is out. Thank you all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants