Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement][API] The relevant configuration parameters of the zookeeper service are missing a Unit of measurement #274

Closed
2 of 3 tasks
datasophon opened this issue Jun 14, 2023 · 2 comments · Fixed by #281 or #301
Closed
2 of 3 tasks

[Improvement][API] The relevant configuration parameters of the zookeeper service are missing a Unit of measurement #274

datasophon opened this issue Jun 14, 2023 · 2 comments · Fixed by #281 or #301
Assignees
@ceohui
Labels
good first issue Good for newcomers

Comments

@datasophon
Copy link
Member

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

缺少计量单位：
image

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct
@datasophon datasophon added the good first issue Good for newcomers label Jun 14, 2023
@github-actions
Copy link

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

缺少计量单位：
image

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@ceohui
Copy link
Contributor

ceohui commented Jun 15, 2023

I want to apply it

ceohui pushed a commit to ceohui/datasophon that referenced this issue Jun 20, 2023
[DS-274][fix] 增加Zookeeper参数单位说明
ad6adc3 
增加Zookeeper参数单位说明
tickTime---心跳时间(毫秒)
initLimit---LF初始通信时限(tickTime的数量(次))
syncLimit---LF同步通信时限(tickTime的数量(次))
zkHeapSize---ZK最大堆内存(GB)
This closes datavane#274
@ceohui ceohui mentioned this issue Jun 20, 2023
Merged
datasophon pushed a commit that referenced this issue Jun 20, 2023
@ceohui
[DS-274][fix] 增加Zookeeper参数单位说明 (#281)
f183ace 
增加Zookeeper参数单位说明
tickTime---心跳时间(毫秒)
initLimit---LF初始通信时限(tickTime的数量(次))
syncLimit---LF同步通信时限(tickTime的数量(次))
zkHeapSize---ZK最大堆内存(GB)
This closes #274

Co-authored-by: 何辉 <hehui3@asiainfo.com>
@ceohui ceohui mentioned this issue Jun 29, 2023
Merged
datasophon pushed a commit that referenced this issue Jun 29, 2023
@ceohui
[DS-274][fix] 增加Zookeeper参数单位说明 (#301)
bb752d1 
增加Zookeeper参数单位说明
tickTime---心跳时间(毫秒)
initLimit---LF初始通信时限(tickTime的数量(次))
syncLimit---LF同步通信时限(tickTime的数量(次))
zkHeapSize---ZK最大堆内存(GB)
This closes #274

Co-authored-by: 何辉 <hehui3@asiainfo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ceohui ceohui

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
2 participants
@ceohui @datasophon