Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perf] Remove some constant in class Constants, and use SFunction instead. #200

Merged
merged 1 commit into from
Mar 6, 2023

Conversation

WujieRen
Copy link
Collaborator

@WujieRen WujieRen commented Mar 5, 2023

Purpose of the pull request

Remove some constant in class Constants, and use SFunction instead.

Brief change log

Remove constant Constants.ID/ALERT_GROUP_ID/ALERT_QUOTA_NAME/ALERT_GROUP_NAME/ALERT_LEVEL, and use SFunction instead.

Verify this pull request

This pull request is code cleanup without any test coverage.

…ERT_GROUP_NAME/ALERT_LEVEL, and use SFunction instead.
@datasophon datasophon merged commit dabb84b into datavane:dev Mar 6, 2023
datasophon pushed a commit that referenced this pull request Mar 9, 2023
* fix ui deploy

* add npmDownloadRoot

* fix:修复运行报错问题

* feat:将前端产物“搬运”到指定目录

* feat:publicPath设置(/${path},后端配置)

* replace path to /ddh

* feat:前端文件移动,路径配置(/ddh)

* fix ui deploy

* revert some code

* revert some code

* [Improvement-190][MinaUtils] Improve get id_rsa file path to support different user home path on MinaUtils (#191)

* 1.delete read hosts file code and host_ip/ip_host cache
2.add utils get ip and hostname use InetAddress
3.delete  unused code related this functions

* Improve get id_rsa file path on MinaUtils

---------

Co-authored-by: chenshaosong <chenss131@chinaunicom.cn>

* perf: Remove constant Constants.ID/ALERT_GROUP_ID/ALERT_QUOTA_NAME/ALERT_GROUP_NAME/ALERT_LEVEL, and use SFunction instead. (#200)

* A bug fix for querying the list of all service roles (#202)

* perf: Remove constant Constants.ID/ALERT_GROUP_ID/ALERT_QUOTA_NAME/ALERT_GROUP_NAME/ALERT_LEVEL, and use SFunction instead.

* fix: NullpointerException will be thrown, when target value of query is null.

* add   options.mode = 'history'

* add   options.mode = 'history'

* revert

* fix some error

---------

Co-authored-by: huangli <huangli@iflytek.com>
Co-authored-by: chenss <shaosongfirst@163.com>
Co-authored-by: chenshaosong <chenss131@chinaunicom.cn>
Co-authored-by: renwujie <rwj005@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants