[Fix][Connector] Support some issues with oracle (#396)

* [Update][Connector] Support with oracle regular expression checking * [Update][Connector] Support fetching the primary key of oracle
datavane · May 7, 2024 · 321dc0a · 321dc0a
1 parent 7439f40
commit 321dc0a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/...tavines-connector-oracle/src/main/java/io/datavines/connector/plugin/OracleConnector.java b/...tavines-connector-oracle/src/main/java/io/datavines/connector/plugin/OracleConnector.java
@@ -46,6 +46,11 @@ public ResultSet getMetadataTables(DatabaseMetaData metaData, String catalog, St
         return metaData.getTables(null,schema.toUpperCase(), null, TABLE_TYPES);
     }
 
+    @Override
+    protected ResultSet getPrimaryKeys(DatabaseMetaData metaData, String catalog, String schema, String tableName) throws SQLException {
+        return metaData.getPrimaryKeys(null, schema.toUpperCase(), tableName);
+    }
+
     @Override
     public ResultSet getMetadataDatabases(Connection connection) throws SQLException {
         java.sql.Statement stmt = connection.createStatement();

diff --git a/...datavines-connector-oracle/src/main/java/io/datavines/connector/plugin/OracleDialect.java b/...datavines-connector-oracle/src/main/java/io/datavines/connector/plugin/OracleDialect.java
@@ -28,6 +28,8 @@ public Map<String, String> getDialectKeyMap() {
         super.getDialectKeyMap();
         dialectKeyMap.put(STRING_TYPE, "VARCHAR2");
         dialectKeyMap.put(LIMIT_TOP_50_KEY, " rownum <= 50");
+        dialectKeyMap.put(REGEX_KEY, "regexp_like(${column},'${regexp}')");
+        dialectKeyMap.put(NOT_REGEX_KEY, "not regexp_like(${column},'${regexp}')");
         dialectKeyMap.put(IF_CASE_KEY, "case when ${column} is null then 'NULL' else ${column}||'' end ");
         return dialectKeyMap;
     }