Set min/max domain for number col domain

Related to #718 The parameter default, i.e. `min = Number.NaN`, is only used if the parameter is `undefined`. However, when the parameter is `null` it does not assign `Number.NaN`. With this commit `null` and `undefined` result in `Number.NaN`.
datavisyn · Jul 22, 2022 · 2158e1f · 2158e1f
1 parent a067102
commit 2158e1f
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/dist/lineup/desc.d.ts.map b/dist/lineup/desc.d.ts.map
diff --git a/dist/lineup/desc.js b/dist/lineup/desc.js
diff --git a/dist/lineup/desc.js.map b/dist/lineup/desc.js.map
diff --git a/src/lineup/desc.ts b/src/lineup/desc.ts
@@ -76,10 +76,10 @@ export class ColumnDescUtils {
    * @param {Partial<IColumnOptions>} options
    * @returns {IAdditionalColumnDesc}
    */
-  static numberCol(column: string, min: number = Number.NaN, max: number = Number.NaN, options: Partial<IColumnOptions> = {}): IAdditionalColumnDesc {
+  static numberCol(column: string, min?: number, max?: number, options: Partial<IColumnOptions> = {}): IAdditionalColumnDesc {
     return Object.assign(ColumnDescUtils.baseColumn(column, options), {
       type: 'number',
-      domain: [min, max],
+      domain: [min || Number.NaN, max || Number.NaN],
     });
   }