Skip to content

Commit

Permalink
Merge pull request #351 from datavisyn/thinkh/346_ignore-live-preview…
Browse files Browse the repository at this point in the history
…-events

Ignore live preview events
  • Loading branch information
thinkh authored Apr 14, 2020
2 parents f027d02 + 7894c09 commit 79d8f48
Show file tree
Hide file tree
Showing 4 changed files with 375 additions and 119 deletions.
3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,8 @@
"lineupjs": "github:lineupjs/lineupjs#lineup-v4",
"phovea_clue": "github:phovea/phovea_clue#develop",
"select2": "~4.0.13",
"select2-bootstrap-theme": "0.1.0-beta.9"
"select2-bootstrap-theme": "0.1.0-beta.9",
"lodash": "~4.17.15"
},
"main": "build/tdp_core.js",
"devDependencies": {
Expand Down
7 changes: 6 additions & 1 deletion src/lineup/ARankingView.ts
Original file line number Diff line number Diff line change
Expand Up @@ -293,6 +293,11 @@ export abstract class ARankingView extends AView {
violationChanged: (_: IRule, violation: string) => this.panel.setViolation(violation)
}));

// LineUp creates an element with class `lu-backdrop` that fades out all content when a dialog is opened.
// Append `lu-backdrop` one level higher so fading effect can be applied also to the sidePanel when a dialog is opened.
const luBackdrop = this.node.querySelector('.lu-backdrop');
this.node.appendChild(luBackdrop);

this.panel = new LineUpPanelActions(this.provider, this.taggle.ctx, this.options, this.node.ownerDocument);
this.panel.on(LineUpPanelActions.EVENT_SAVE_NAMED_SET, (_event, order: number[], name: string, description: string, sec: Partial<ISecureItem>) => {
this.saveNamedSet(order, name, description, sec);
Expand Down Expand Up @@ -608,7 +613,7 @@ export abstract class ARankingView extends AView {
this.builtLineUp(this.provider);

//record after the initial one
clueify(this.context.ref, this.context.graph);
clueify(this.taggle, this.context.ref, this.context.graph);
this.setBusy(false);
}).catch(showErrorModalDialog)
.catch((error) => {
Expand Down
Loading

0 comments on commit 79d8f48

Please sign in to comment.