Skip to content

Commit

Permalink
Add structured image column, renderer, and filter dialog for SMILES s…
Browse files Browse the repository at this point in the history
…trings to ranking (#755)

* Add molecule column + renderer for LineUp

#741

* Implement fetch structured image

#741

* Add SMILES renderer and column to Ranking.tsx

#741

* Adapt to latest rdkit API changes

* Add custom structure image filter dialog (wip)

* Add loading icon + error msg to filter dialog

* Remove orphan import

* Fix linter warnings and improve code

* Deny to set string filter

* Fix lint

* Fix `filter = null` case

* Rename folder to `structureImage` and add index.ts

* Update dist files

* Add empty summary renderer

Otherwise an error is thrown when switching visualizations for the smiles column

* Fix lint

* Nest structured image i18n strings

* Set default column width for smiles column

* Set row height based on smiles column width

* Set min/max domain for number col domain

Related to #718

The parameter default, i.e. `min = Number.NaN`, is only used if the parameter is `undefined`. However, when the parameter is `null` it does not assign `Number.NaN`.

With this commit `null` and `undefined` result in `Number.NaN`.

* Set default summary renderer for smiles col

* StructuredImageColumn extends ValueColumn

- Removes all string related dialogs and functionality (e.g., group, sort, ...)
- Add rename dialog
- Remove `order` to default -> in menu: rename then filter

Co-authored-by: Michael Puehringer <michael.puehringer@datavisyn.io>
Co-authored-by: Michael Pühringer <51900829+puehringer@users.noreply.github.com>
  • Loading branch information
3 people authored Aug 26, 2022
1 parent 38bdcc3 commit e7a418e
Show file tree
Hide file tree
Showing 36 changed files with 946 additions and 30 deletions.
1 change: 1 addition & 0 deletions dist/lineup/Ranking.d.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/lineup/Ranking.d.ts.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

77 changes: 72 additions & 5 deletions dist/lineup/Ranking.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/lineup/Ranking.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/lineup/desc.d.ts.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions dist/lineup/desc.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit e7a418e

Please sign in to comment.