pass options from CompositeView to detail views, since they may need … #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lehnerchristian Is there a related issue for this PR? |
nope, this issue came up on the fly yesterday. the problem is that detail views can get additional options if they need them (such as an AppState if they need to operate on the state). also the CompositeView gets the additional options, but it needs to pass them to the detail views, because they need the options in reality, not the CompositeView itself see also https://github.com/datavisyn/tdp_core/blob/master/src/extensions.ts#L307 I'll create a ticket with this text and link it |
|
updated the description |
dg-datavisyn
approved these changes
Sep 26, 2019
28 tasks
27 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…them
closes #223