Enable AView to process 1:n mappings by id and by name #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable AView to resolve 1:n mappings. #230
thinkh
requested changes
Oct 14, 2019
Co-Authored-By: Holger Stitz <holger.stitz@datavisyn.io>
Co-Authored-By: Holger Stitz <holger.stitz@datavisyn.io>
…_core into dgirardi/230_1toN_mappings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #230
Summary
The resolveSelection method of AView internally relies on the numeric _id value and only maps to the first targetIdType element. This value is not always known to external MappingProviders. So a mapping by name is also needed. Additionally, the AView is now also able to resolve 1:n mappings and not just 1:1 mappings.
This change causes a new minor version.