Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to Python 3.7 #270

Merged
merged 42 commits into from
Jan 2, 2020
Merged

Migrate to Python 3.7 #270

merged 42 commits into from
Jan 2, 2020

Conversation

dvvanessastoiber
Copy link
Contributor

@dvvanessastoiber dvvanessastoiber commented Dec 13, 2019 •
edited by thinkh
Loading

Required PR phovea/phovea_server#89

Changes according to wiki page

Summary

  • Use new Python 3.7 syntax and adapt import statements accordingly
  • Use adequate Docker and CircleCi images
  • Update requirements.txt and requirements_dev.txt
  • Remove .gitlab-ci.yml

dvvanessastoiber and others added 30 commits September 12, 2019 13:05
@dvvanessastoiber
Update python requirements for Python 3.7
00d9d65
@dvvanessastoiber
Use CircleCI Docker image circleci/python:3.7-node-browsers
1129758 
- in /.circleci/config.yml and gitlab-ci.yml
- set environment variable NODE_VERSION: 10.16.3 for this
Docker image
@dvvanessastoiber
Replace python tests py27 and py34 with py37
b534f5d 
in _.travis.yml_ and _tox.ini_
@dvvanessastoiber
Update python _setup.py_ classifiers to Python 3.7
6e933aa
@dvvanessastoiber
Remove .encode('ascii') from _setup.py_
aff78b8
@dvvanessastoiber
use lib2to3 to convert files to Python 3
fbe0d39
@dvvanessastoiber
add list() to columns parameter
d38b169 
`.values()` does not return an array in Python 3 but
wraps a `dict_values` wrapper around the data instead
-> use call to `list`
@dvvanessastoiber
remove .message attribute
4dbc1f9
@dvvanessastoiber
decode ids of type bytes
8199994
@dvvanessastoiber
correct import of WriteOnlyCell
da4251a 
from `openpyxl.cell` instead of
 `openpyxl.worksheet.write_only` -> otherwise
module not found error
@dvvanessastoiber
pass dict.keys() to list
bce107a 
In Python 3, `d.keys()` returns an iterable instead of a `list`
@dvvanessastoiber
correct mistake in basepython
54ee603
@dvvanessastoiber
create BytesToStringEncoder
2e05a23
@dvvanessastoiber
remove .decode()
70b79d2 
done by  `BytesToStringEncoder`
@dvvanessastoiber
pass .keys(), .values(), .items() to list
de19444 
the functions return an `iterable` in Python 3
@dvvanessastoiber
remove unnecessary comments and print statements
15a32b9 
used for testing
@dvvanessastoiber
convert list to string for Excel
d7acbe9 
Openpyxl does not allow you to write lists in
excel cells. By converting the `list` into a `string`
you can paste it into excel.
@thinkh
Merge branch 'develop' into python_3.7
5a7e523 
# Conflicts:
#	tdp_core/sql_filter.py
@dvvanessastoiber
remove .message attribute from error
9604b4c 
no longer available in Python 3
@dvvanessastoiber
pass .items() to list()
3190259
@dvvanessastoiber
pass to list() to avoid errors with iterables
8327460
@dvvanessastoiber
remove _travis.yml_
a895637
@dvvanessastoiber
switch branches in _requirements.txt_
0aa8afd
@dvvanessastoiber
update node-sass
103e9bd
@dvvanessastoiber
remove unused import
0f04772
@dvvanessastoiber
remove whitespace
bc8eb35
@dvvanessastoiber
rename variable
876cea7
@dvvanessastoiber
convert value to string
022818c
@dvvanessastoiber
switch branches in _requirements.txt_
287c823
@dvvanessastoiber
remove double_precision
34829ec 
required pandas module has been removed

https://pandas.pydata.org/pandas-docs/stable/whatsnew/v0.24.0.html#removal-of-prior-version-deprecations-changes
@dvvanessastoiber dvvanessastoiber added the type: refactor Refactor the current implementation label Dec 13, 2019
@dvvanessastoiber dvvanessastoiber requested review from thinkh and a user December 13, 2019 06:26
@dvvanessastoiber dvvanessastoiber assigned thinkh and ghost Dec 13, 2019
@ghost ghost removed the request for review from thinkh December 16, 2019 06:39
@ghost ghost unassigned thinkh Dec 16, 2019
@thinkh thinkh added the release: major PR merge results in a new major version label Jan 2, 2020
@thinkh thinkh marked this pull request as ready for review January 2, 2020 14:30
thinkh
thinkh approved these changes Jan 2, 2020
View reviewed changes
Copy link
Member

@thinkh thinkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for you work. Looks good! 👍

@thinkh thinkh self-assigned this Jan 2, 2020
@thinkh thinkh merged commit 25ec984 into develop Jan 2, 2020
@thinkh thinkh deleted the python_3.7 branch January 2, 2020 14:41
@thinkh thinkh mentioned this pull request Jan 13, 2020
Merged
29 tasks
@ghost ghost mentioned this pull request Mar 19, 2020
Open
6 tasks
This was referenced Mar 19, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkh thinkh thinkh approved these changes

Assignees

@thinkh thinkh

Labels
release: major PR merge results in a new major version type: refactor Refactor the current implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dvvanessastoiber @thinkh