Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix date values in language strings #298

Merged
merged 2 commits into from
Feb 5, 2020
Merged

Fix date values in language strings #298

merged 2 commits into from
Feb 5, 2020

Conversation

dvvanessastoiber
Copy link
Contributor

Fixes #297

Related to Caleydo/tdp_bi_bioinfodb#1055

Summary

  • add variable count to language strings to display date values correctly
  • remove duplicate code that has become obsolete after the migration to Python 3.7

@dvvanessastoiber dvvanessastoiber added type: bug Something isn't working priority: medium labels Feb 3, 2020
thinkh
thinkh approved these changes Feb 5, 2020
View reviewed changes
Copy link
Member

@thinkh thinkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. 👍

@thinkh thinkh merged commit bc2ea12 into develop Feb 5, 2020
@thinkh thinkh deleted the stoiber/297_date_of_persistent_sessions_not_correct branch February 5, 2020 10:58
@thinkh thinkh mentioned this pull request Feb 7, 2020
Closed
@dvvanessastoiber dvvanessastoiber mentioned this pull request Mar 18, 2020
Merged
29 tasks
@datavisyn-bot datavisyn-bot mentioned this pull request Mar 19, 2020
Closed
2 tasks
@ghost ghost mentioned this pull request Mar 19, 2020
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkh thinkh thinkh approved these changes

Assignees

@thinkh thinkh

Labels
priority: medium type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dvvanessastoiber @thinkh