Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derive set column categories automatically #353

Merged
merged 5 commits into from
Jul 14, 2020

Conversation

oltionchampari
Copy link
Contributor

Summary

It would be nice to have the feature to derive set columns categories in the backend as is the
case for categorical columns when calling the DBViewBuilder.derive_columns() method.

This feature is especially beneficial when the categories of the column depend on the selected IDs from the previous view.

@oltionchampari oltionchampari added type: feature New feature or request release: minor PR merge results in a new minor version labels Apr 14, 2020
@oltionchampari oltionchampari requested a review from thinkh April 14, 2020 09:30
Base automatically changed from lineupjs4 to develop June 15, 2020 12:45
@thinkh thinkh marked this pull request as ready for review July 14, 2020 14:45
@thinkh thinkh requested a review from lehnerchristian as a code owner July 14, 2020 14:45
By sorting the categories list the order of categories is maintained. Without sorting the category order is different with every run.
Copy link
Member

@thinkh thinkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good! 👍

@thinkh thinkh merged commit 6e50dab into develop Jul 14, 2020
@thinkh thinkh deleted the derive-set-column-categories branch July 14, 2020 15:27
@thinkh thinkh mentioned this pull request Jul 30, 2020
48 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: minor PR merge results in a new minor version type: feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants