Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix truncated select2 and select3 placholder #382

Merged
merged 1 commit into from
Jun 23, 2020
Merged

Fix truncated select2 and select3 placholder #382

merged 1 commit into from
Jun 23, 2020

Conversation

thinkh
Copy link
Member

@thinkh thinkh commented Jun 22, 2020

Fixes #381

Related PR: Caleydo/tdp_gene#135

Summary

Solution from select2/select2#4898 (comment)

grafik

grafik

grafik

@oltionchampari Please check if it works for you in Ordino

@lehnerchristian Please cross-check if it works in some other apps.

@thinkh thinkh added type: bug Something isn't working release: patch PR merge results in a new patch version labels Jun 22, 2020
@thinkh thinkh linked an issue Jun 22, 2020 that may be closed by this pull request
Select2 and Select3 placeholder is truncated #381
Closed
@lehnerchristian
Copy link

lehnerchristian commented Jun 23, 2020 •
edited
Loading

I've tested this in another application and it looks fine now 👍

oltionchampari
oltionchampari approved these changes Jun 23, 2020
View reviewed changes
Copy link
Contributor

@oltionchampari oltionchampari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in Ordino. All the dialogs / forms look good.

@thinkh
Copy link
Member Author

thinkh commented Jun 23, 2020

Thanks for testing!

@thinkh thinkh merged commit 0541ccc into develop Jun 23, 2020
@thinkh thinkh deleted the thinkh/381_fix-select2-placeholder branch June 23, 2020 12:03
thinkh added a commit that referenced this pull request Jul 29, 2020
@thinkh
Re-add missing select2 placeholder #382
d2c85da 
With the merge of the refactoring branches this code snippet got lost.
@thinkh thinkh mentioned this pull request Jul 29, 2020
Merged
dg-datavisyn added a commit that referenced this pull request Jul 29, 2020
@dg-datavisyn
Merge pull request #404 from datavisyn/thinkh/382_fix-select2-placeho…
39f21d0 
…lder-revisited

Re-add missing select2 placeholder of PR #382
@thinkh thinkh mentioned this pull request Jul 30, 2020
Merged
48 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oltionchampari oltionchampari oltionchampari approved these changes

@lehnerchristian lehnerchristian lehnerchristian approved these changes

Assignees

@lehnerchristian lehnerchristian

@oltionchampari oltionchampari

Labels
release: patch PR merge results in a new patch version type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Select2 and Select3 placeholder is truncated
3 participants
@thinkh @lehnerchristian @oltionchampari