Track in provenance graph thegroupingChanged LineUp event
#385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oltionchampari
added
type: feature
Previously the event listener was added to event + `Changed.track` but removed from event + `Changed.filter`. This commit corrects and unifies the event name.
thinkh
requested changes
Jun 30, 2020
| * The return value of this function can be passed to `JSON.stringify()` and stored in the provenance graph. | ||
| * @param groupBy Value returned from the `Group By` dialog | ||
| */ | ||
| export function serializeGroupByValue(groupBy: IStringGroupCriteria) { |
There was a problem hiding this comment.
Could you please add some unit tests for this function?
| * Restores LineUp StringColumn's Group By` dialog's values from the provenance graph and returns an `IStringGroupCriteria`. | ||
| * @param groupBy Value as saved in the provenance graph. | ||
| */ | ||
| export function restoreGroupByValue(groupBy: ISerializedStringGroupCriteria) { |
There was a problem hiding this comment.
Could you please add some unit tests for this function?
There was a problem hiding this comment.
@thinkh I added test for the serialize and restore functions. You can take a look again when you have time.
…ng_column_group_by_cmd_bug # Conflicts: # src/lineup/internal/cmds.ts
thinkh
approved these changes
Jul 1, 2020
There was a problem hiding this comment.
@oltionchampari Thanks for the additional unit tests! Now it looks good. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #379
Summary
Set Property grouping.The events
StringColumn.EVENT_GROUPING_CHANGEDandRanking.EVENT_GROUP_CRITERIA_CHANGED,never intersect apart from when the groupBy dialog is set for the first time.
Screenshot