Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added options forwarding to provenance graph storage manager #409

Merged
merged 1 commit into from
Aug 11, 2020
Merged

Added options forwarding to provenance graph storage manager #409

merged 1 commit into from
Aug 11, 2020

Conversation

puehringer
Copy link
Contributor

thinkh
thinkh approved these changes Aug 6, 2020
View reviewed changes
Copy link
Member

@thinkh thinkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but still need to fix CircleCI.

@puehringer
Copy link
Contributor Author

@thinkh CI only fails because phovea/phovea_core#196 is not merged yet, after merging the build should pass.

@lehnerchristian lehnerchristian merged commit 35caff3 into develop Aug 11, 2020
@lehnerchristian lehnerchristian deleted the mp/408_prov_graph_options branch August 11, 2020 08:00
@thinkh thinkh added the release: patch PR merge results in a new patch version label Aug 12, 2020
@dvvanessastoiber dvvanessastoiber mentioned this pull request Aug 13, 2020
Merged
48 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkh thinkh thinkh approved these changes

@lehnerchristian lehnerchristian Awaiting requested review from lehnerchristian

Assignees

@lehnerchristian lehnerchristian

@thinkh thinkh

Labels
release: patch PR merge results in a new patch version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@puehringer @thinkh @lehnerchristian