Removed Exception constraint in DBMigration upgrade except #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puehringer
force-pushed
the
mp/415_dbmigration_exception_fix
branch
from
8fe33a9 to
662b85b
Compare
|
@lehnerchristian |
lehnerchristian
approved these changes
Sep 7, 2020
thinkh
approved these changes
Sep 8, 2020
thinkh
added
type: bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #415.
Alembic raises exceptions which were previously not caught by the
except Exceptionclause, causing the server startup to fail if a specific revision could not be identified (DB is on new branch version, code is on older branch) for example.Now, everything is caught properly.