Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove internal ids #615

Merged
merged 31 commits into from
Mar 17, 2022
Merged

Remove internal ids #615

merged 31 commits into from
Mar 17, 2022

Conversation

puehringer
Copy link
Contributor

@puehringer puehringer commented Jan 26, 2022

Remove internal ids and all mechanisms regarding internal id-mapping, including the redis dependency.

  • Remove redis from requirements.txt, docker-compose*.yml, redis_mapping_table, ...
  • Remove all mapToName, unmap, ... functions as no internal ids are available anymore.
  • Remove Range as it was only used for selections utilizing internal ids.
  • ...

How to migrate repos:

  • In your workspace, switch all repos to the remove_internal_ids branch if it exists.
  • Run npm run compile:<reponame> to check if any errors occur.
  • Fix all errors (contact @puehringer if any questions arise).
  • Commit all changes to a new remove_internal_ids branch and create a draft PR.

@puehringer puehringer marked this pull request as ready for review March 17, 2022 07:41
@puehringer puehringer merged commit 4866d9f into develop Mar 17, 2022
@puehringer puehringer deleted the remove_internal_ids branch March 17, 2022 07:41
@dvvanessastoiber dvvanessastoiber mentioned this pull request Apr 5, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants