Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make SQLAlchemy pool class configurable + add tracer to db.py and dbview.py #855

Merged
merged 7 commits into from
Aug 23, 2023
Merged

feat: make SQLAlchemy pool class configurable + add tracer to db.py and dbview.py #855

merged 7 commits into from
Aug 23, 2023

Conversation

thinkh
Copy link
Member

@thinkh thinkh commented Aug 18, 2023 •
edited
Loading

Related issue: https://github.com/Caleydo/tdp_bi_bioinfodb/issues/1439

Developer Checklist (Definition of Done)

Issue

  • All acceptance criteria from the issue are met
  • Tested in latest Chrome/Firefox

UI/UX/Vis

  • Requires UI/UX/Vis review
    • Reviewer(s) are notified (tag assignees)
    • Review has occurred (link to notes)
    • Feedback is included in this PR
    • Reviewer(s) approve of concept and design

Code

  • Branch is up-to-date with the branch to be merged with, i.e., develop
  • Code is cleaned up and formatted
  • Unit tests are written (frontend/backend if applicable)
  • Integration tests are written (if applicable)

PR

  • Descriptive title for this pull request is provided (will be used for release notes later)
  • Reviewer and assignees are defined
  • Add type label (e.g., bug, feature) to this pull request
  • Add release label (e.g., release: minor) to this PR following semver
  • The PR is connected to the corresponding issue (via Closes #...)
  • Summary of changes is written

Summary of changes

  • make SQLAlchemy pool class configurable
  • add tracer to db.py and dbview.py

Screenshots

Additional notes for the reviewer(s)

Thanks for creating this pull request 🤗

@thinkh thinkh added type: feature New feature or request release: patch PR merge results in a new patch version release: minor PR merge results in a new minor version and removed release: patch PR merge results in a new patch version labels Aug 18, 2023
thinkh added 6 commits August 22, 2023 15:59
@thinkh
fix: make lint
2366eb5
@thinkh
fix: use a single with statement
81654b1 
Fix lint error: SIM117 Use a single `with` statement with multiple contexts instead of nested `with` statements
@thinkh
fix: make format
92fd31c
@thinkh
feat: make poolclass configurable
c87eb3b 
Default class is QueuePool with default engine options.

If a custom poolclass is set the default engine options are empty and must be set manually.
@thinkh
fix: import queue pool in root
2870495
@thinkh
fix: pyright
5c29704
@thinkh thinkh changed the title feat: add tracer to db.py and dbview.py feat: make SQLAlchemy pool class configurable + add tracer to db.py and dbview.py Aug 23, 2023
@thinkh thinkh mentioned this pull request Aug 23, 2023
Merged
17 tasks
@thinkh thinkh requested a review from puehringer August 23, 2023 10:05
@thinkh thinkh self-assigned this Aug 23, 2023
@thinkh thinkh marked this pull request as ready for review August 23, 2023 10:05
@thinkh thinkh requested a review from a team as a code owner August 23, 2023 10:05
@puehringer puehringer merged commit 2486542 into develop Aug 23, 2023
@puehringer puehringer deleted the thinkh/add-telemetry-to-db-and-dbview branch August 23, 2023 10:09
@thinkh thinkh mentioned this pull request Aug 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@puehringer puehringer puehringer approved these changes

Assignees

@thinkh thinkh

Labels
release: minor PR merge results in a new minor version type: feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thinkh @puehringer