Skip to content
This repository has been archived by the owner on Jan 13, 2023. It is now read-only.

Show easy understood message when fetch error occur #125

Merged
merged 3 commits into from
Aug 18, 2021

Conversation

WatanabeToshimitsu
Copy link
Contributor

@WatanabeToshimitsu WatanabeToshimitsu commented Aug 5, 2021

What?

  • Show easy understood message when server error responses is returned
  • Stop showing "Please reload this page" when fetch error occur

Why?

  • To improve usability
  • The message have no mean, and sometimes lead misunderstanding

See also

Screenshot or video

image

@hdl-service hdl-service requested a review from yusukefs August 5, 2021 02:42
@hdl-service hdl-service added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 5, 2021
@WatanabeToshimitsu WatanabeToshimitsu changed the title Show easy understood message when fetch error occur [WIP] Show easy understood message when fetch error occur Aug 5, 2021
@hdl-service hdl-service added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 5, 2021
@WatanabeToshimitsu WatanabeToshimitsu changed the title [WIP] Show easy understood message when fetch error occur Show easy understood message when fetch error occur Aug 16, 2021
@hdl-service hdl-service removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 16, 2021
Copy link
Contributor

@yusukefs yusukefs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hdl-service hdl-service added the lgtm Indicates that a PR is ready to be merged. label Aug 18, 2021
@hdl-service
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: WatanabeToshimitsu, yusukefs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [WatanabeToshimitsu,yusukefs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hdl-service hdl-service merged commit 0a63af5 into master Aug 18, 2021
@hdl-service hdl-service deleted the fix/error-message branch August 18, 2021 05:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants