Skip to content
This repository has been archived by the owner on Jan 13, 2023. It is now read-only.

Apply delete mode for confirm modal on deleting #128

Merged
merged 2 commits into from
Aug 16, 2021

Conversation

yusukefs
Copy link
Contributor

What?

app-common をアップデートし各種削除時の確認モーダルで削除用のスタイルを設定

  • データベース削除
  • レコード削除
  • ファイル削除

Why?

削除確認モーダルのスタイルをわかりやすくしたい

See also [Optional]

Screenshot or video [Optional]

スクリーンショット 2021-08-13 16 00 04

スクリーンショット 2021-08-13 16 00 12

スクリーンショット 2021-08-13 16 00 21

@hdl-service hdl-service requested a review from d-hayashi August 13, 2021 07:04
@hdl-service hdl-service added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 13, 2021
@yusukefs yusukefs requested review from WatanabeToshimitsu and removed request for d-hayashi August 13, 2021 07:04
Copy link
Contributor

@WatanabeToshimitsu WatanabeToshimitsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hdl-service hdl-service added the lgtm Indicates that a PR is ready to be merged. label Aug 16, 2021
@hdl-service
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: WatanabeToshimitsu, yusukefs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [WatanabeToshimitsu,yusukefs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hdl-service hdl-service merged commit 6b43f72 into master Aug 16, 2021
@hdl-service hdl-service deleted the feature/use-delete-mode-for-confirm-delete branch August 16, 2021 01:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants