Skip to content
This repository has been archived by the owner on Jan 13, 2023. It is now read-only.

Refactoring #137

Merged
merged 1 commit into from
Sep 1, 2021
Merged

Refactoring #137

merged 1 commit into from
Sep 1, 2021

Conversation

WatanabeToshimitsu
Copy link
Contributor

What?

  • Use sx props instead of makeStyles
  • Fix code format

Why?

@hdl-service hdl-service requested a review from yusukefs August 31, 2021 02:39
@hdl-service hdl-service added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 31, 2021
@WatanabeToshimitsu
Copy link
Contributor Author

@yusukefs ロジックは一切弄ってないのでサクッと確認してもらえれば幸いです

yusukefs
yusukefs approved these changes Sep 1, 2021
View reviewed changes
Copy link
Contributor

@yusukefs yusukefs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

だいぶスッキリしましたね
LGTM!

@hdl-service hdl-service added the lgtm Indicates that a PR is ready to be merged. label Sep 1, 2021
@hdl-service
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: WatanabeToshimitsu, yusukefs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [WatanabeToshimitsu,yusukefs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hdl-service hdl-service merged commit 4c7140c into master Sep 1, 2021
@hdl-service hdl-service deleted the refactoring branch September 1, 2021 04:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yusukefs yusukefs yusukefs approved these changes

Assignees

@yusukefs yusukefs

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WatanabeToshimitsu @hdl-service @yusukefs