Skip to content
This repository has been archived by the owner on Jan 13, 2023. It is now read-only.

Bump @typescript-eslint/eslint-plugin from 4.31.0 to 4.33.0 #165

Merged
merged 1 commit into from
Oct 14, 2021
Merged

Bump @typescript-eslint/eslint-plugin from 4.31.0 to 4.33.0 #165

merged 1 commit into from
Oct 14, 2021

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 11, 2021 •
edited
Loading

Bumps @typescript-eslint/eslint-plugin from 4.31.0 to 5.0.0.

Release notes

Sourced from @​typescript-eslint/eslint-plugin's releases.

v5.0.0

5.0.0 (2021-10-11)

Breaking Release Notes

All Packages

  • Support for ESLint v8 (see individual packages for relevant breaking changes).
  • Drop support for Node v10 - required node version is now ^12.22.0 || ^14.17.0 || >=16.0.0.
    • Node v10 was EOL'd in April 2021, and ESLint v8 dropped support for it too.
  • Drop Support for ESLint v5
    • ESLint v5 is now 3 years old - why are you still using it? Upgrade to at least ESLint v6.

ESLint-Plugin

  • Changes to the recommended rule set - see #3746
  • [ban-types] remove object from the default ban list
    • This has been a point of contention for a while - I originally added it because TS currently makes it impossible to narrow the type nicely. However there ultimately isn't a good alternative to this type for many usecases. As such we're removing the default ban. If you want to continue banning it, you can configure the rule to do so.
  • [comma-dangle] align schema with ESLint v8
    • Should be pretty transparent unless you were using an invalid config.
  • [explicit-member-accessibility] now checks abstract members
  • [member-ordering] add support for getters and setters
    • This will likely cause your codebase's sort orders to change if you're using the default config.
  • [no-unused-vars-experimental] rule has been deleted
    • You should instead use @typescript-eslint/no-unused-vars instead! It has had full and awesome support for TypeScript since v4.9.0 - and it doesn't require type information!

Experimental-Utils:

  • Remove SourceCode#getComments API from ESLint types.
    • This API was deprecated in ESLint v4, and its usage will error in ESLint v8.
  • Support ESLint v8:
    • CLIEngine is now conditionally undefined. It was deprecated in v7 and removed in v8. If you're still using it, you should upgrade to the ESLint API.
    • Remove meta.docs.category. ESLint has removed this from their core rules as it wasn't ever very useful and was always poorly done. We have followed suit and removed it from our types and our rules.

TypeScript-ESTree / AST-Spec

  • Change .source of ExportNamedDeclaration, ExportAllDeclaration and ImportDeclaration to StringLiteral and add parse-time errors.
    • This ensures we're aligned with ESTree and producing the correct AST.
  • Remove TSParenthesizedType node.
    • This node was added when this project was first created because the TS-AST includes this node. However it ultimately conveys no actual AST meaning (just like parentheses in non-type code). Babel removed this node earlier this year.
    • We expect rules will continue to "just work". In a lot of cases rules will work better as they no longer need manual checks to "look past" the useless node.
  • Remove legacy option useJSXTextNode.
    • This option was added for compatibility between different ASTs a very long time ago - but all ASTs have converged on using JSXText - so you should be using that too.
  • Align class features AST with ESTree. This aligns with ESLint v8.
    • ClassProperty is now called PropertyDefinition
    • TSAbstractClassProperty is now called TSAbstractPropertyDefinition
  • TSAbstractPropertyDefinition.value is now always null.
    • It never made sense that this was allowed, and TS4.4 has now made this invalid.
  • Add full support for PrivateIdentifier (#private class members)
    • Previously we did not officially support them and emitted an "unstable" AST.

... (truncated)

Changelog

Sourced from @​typescript-eslint/eslint-plugin's changelog.

5.0.0 (2021-10-11)

Bug Fixes

  • eslint-plugin: [explicit-member-accessibility] report TSAbstractPropertyDefinition and TSAbstractMethodDefinition properly (#3901) (82016f9)
  • eslint-plugin: update new rules from master (#3840) (d88a6b4)
  • update new rules from master (b34fb7e)
  • eslint-plugin: crash in no-dupe-class-members (v5) (#3813) (4b09644)

Features

BREAKING CHANGES

  • eslint-plugin: ban-types no longer reports object by default

4.33.0 (2021-10-04)

Bug Fixes

  • eslint-plugin: [lines-between-class-members] fix exceptAfterOverload for abstract methods (#3943) (240fc65)
  • eslint-plugin: [no-confusing-void-expression] support optional chaining (#3937) (c40dd13)
  • eslint-plugin: [no-restricted-imports] fix crash when no options given (#3947) (edaa3c1)
  • eslint-plugin: [non-nullable-type-assertion-style] false-positive with non-nullish as assertions and types (#3940) (40760f9)
  • eslint-plugin: [padding-line-between-statements] TSModuleBlock should change scope (#3944) (f8f534e)
  • eslint-plugin: [prefer-regexp-exec] check RegExp without flags (#3946) (0868725)

... (truncated)

Commits
  • 101abc7 chore: publish v5.0.0
  • c304a55 chore: bump eslint to 8.0.0
  • dd14064 feat(ast-spec): bring Node objects in line with ESTree (#3771)
  • 09c47b0 chore: cleanup after rebase
  • 82016f9 fix(eslint-plugin): [explicit-member-accessibility] report `TSAbstractPropert...
  • d88a6b4 fix(eslint-plugin): update new rules from master (#3840)
  • b34fb7e fix: update new rules from master
  • ae3fa90 feat(eslint-plugin): remove object from ban-types' default types (#3818)
  • deeb7bb feat(eslint-plugin): update recommended configs (#3809)
  • 4b09644 fix(eslint-plugin): crash in no-dupe-class-members (v5) (#3813)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Oct 11, 2021
@dependabot dependabot bot mentioned this pull request Oct 11, 2021
Closed
@dependabot dependabot bot requested a review from d-hayashi October 11, 2021 22:24
@hdl-service hdl-service added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 11, 2021
@WatanabeToshimitsu
Copy link
Contributor

@dependabot recreate

@dependabot
Bump @typescript-eslint/eslint-plugin from 4.31.0 to 5.0.0
7a8c42e 
Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 4.31.0 to 5.0.0.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v5.0.0/packages/eslint-plugin)

---
updated-dependencies:
- dependency-name: "@typescript-eslint/eslint-plugin"
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/typescript-eslint/eslint-plugin-5.0.0 branch from e6ddd84 to 7a8c42e Compare October 14, 2021 05:31
@hdl-service hdl-service added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 14, 2021
@WatanabeToshimitsu WatanabeToshimitsu changed the title Bump @typescript-eslint/eslint-plugin from 4.31.0 to 5.0.0 Bump @typescript-eslint/eslint-plugin from 4.31.0 to 4.33.0 Oct 14, 2021
@hdl-service
Copy link
Contributor

Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages.

The list of commits with invalid commit messages:

  • 7a8c42e Bump @typescript-eslint/eslint-plugin from 4.31.0 to 5.0.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hdl-service
Copy link
Contributor

Keywords which can automatically close issues and at(@) mentions are not allowed in the title of a Pull Request.

You can edit the title by writing /retitle in a comment.

When GitHub merges a Pull Request, the title is included in the merge commit. To avoid invalid keywords in the merge commit, please edit the title of the PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@WatanabeToshimitsu
Copy link
Contributor

/lgtm
/approve

@hdl-service hdl-service added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2021
@hdl-service
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dependabot[bot], WatanabeToshimitsu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hdl-service hdl-service added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2021
@hdl-service hdl-service merged commit 7b63702 into master Oct 14, 2021
@hdl-service hdl-service deleted the dependabot/npm_and_yarn/typescript-eslint/eslint-plugin-5.0.0 branch October 14, 2021 05:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@WatanabeToshimitsu WatanabeToshimitsu Awaiting requested review from WatanabeToshimitsu

@d-hayashi d-hayashi Awaiting requested review from d-hayashi

Assignees

@WatanabeToshimitsu WatanabeToshimitsu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dependencies Pull requests that update a dependency file do-not-merge/invalid-commit-message javascript Pull requests that update Javascript code lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WatanabeToshimitsu @hdl-service