Skip to content
This repository has been archived by the owner on Jan 13, 2023. It is now read-only.

Make input-columns configurable #173

Merged
merged 4 commits into from
Oct 19, 2021

Conversation

d-hayashi
Copy link
Contributor

What?

  • Make existing input-columns editable with on a modal
  • Add settings of visibility on the modal

Why?

To improve usability

Screenshot or video [Optional]

Before

スクリーンショット 2021-10-14 14 37 31

スクリーンショット 2021-10-14 14 37 48

After

スクリーンショット 2021-10-14 14 38 09

スクリーンショット 2021-10-14 14 38 16

@hdl-service hdl-service added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 14, 2021
@d-hayashi
Copy link
Contributor Author

入力フィールドを追加する時点で is_secret が設定できたほうが直感的だと思ったのでUI/UXを変更してみました

@d-hayashi
Copy link
Contributor Author

Resolve dataware-tools/dataware-tools#84

Copy link
Contributor

@WatanabeToshimitsu WatanabeToshimitsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

あざます
めっちゃ使いやすくなってると思います!!

例の如く細かいとこ指摘させてもらいました

src/components/organisms/InputConfigListItemModal.tsx Outdated Show resolved Hide resolved
src/components/organisms/InputConfigList.tsx Show resolved Hide resolved
Copy link
Contributor

@WatanabeToshimitsu WatanabeToshimitsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hdl-service hdl-service added the lgtm Indicates that a PR is ready to be merged. label Oct 19, 2021
@hdl-service
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: d-hayashi, WatanabeToshimitsu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [WatanabeToshimitsu,d-hayashi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants