Skip to content
This repository has been archived by the owner on Jan 13, 2023. It is now read-only.

Apply display-name to RecordInfo #175

Merged
merged 1 commit into from
Oct 28, 2021

Conversation

d-hayashi
Copy link
Contributor

What?

Support showing display-name instead of the original name in RecordInfo

Why?

To improve visibility

Screenshot or video [Optional]

Before

スクリーンショット 2021-10-14 16 35 56

After

スクリーンショット 2021-10-14 16 36 03

@hdl-service hdl-service requested a review from yusukefs October 14, 2021 07:41
@hdl-service hdl-service added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 14, 2021
Copy link
Contributor

@yusukefs yusukefs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hdl-service hdl-service added the lgtm Indicates that a PR is ready to be merged. label Oct 28, 2021
@hdl-service
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: d-hayashi, yusukefs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hdl-service hdl-service merged commit ec213b9 into master Oct 28, 2021
@hdl-service hdl-service deleted the fix/apply-display-name-to-record-info branch October 28, 2021 04:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants