Skip to content
This repository has been archived by the owner on Jan 13, 2023. It is now read-only.

Hold config after moving to another tab on modal for configuring database #210

Merged
merged 8 commits into from
Nov 2, 2021
Merged

Hold config after moving to another tab on modal for configuring database #210

merged 8 commits into from
Nov 2, 2021

Conversation

WatanabeToshimitsu
Copy link
Contributor

@WatanabeToshimitsu WatanabeToshimitsu commented Oct 28, 2021 •
edited
Loading

What?

Hold config after moving to another tab on modal for configuring database

Why?

To improve UX

See also

Resolves dataware-tools/dataware-tools#83

Screenshot or video

HoldDatabaseConfig

@hdl-service hdl-service added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 28, 2021
@hdl-service hdl-service requested a review from d-hayashi October 28, 2021 10:37
@hdl-service hdl-service added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 28, 2021
@WatanabeToshimitsu WatanabeToshimitsu changed the title [WIP] Hold config after moving to another tab on modal for configuring database Hold config after moving to another tab on modal for configuring database Nov 1, 2021
@hdl-service hdl-service removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 1, 2021
@WatanabeToshimitsu WatanabeToshimitsu changed the title Hold config after moving to another tab on modal for configuring database [WIP] Hold config after moving to another tab on modal for configuring database Nov 1, 2021
@hdl-service hdl-service added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 1, 2021
@WatanabeToshimitsu WatanabeToshimitsu changed the title [WIP] Hold config after moving to another tab on modal for configuring database Hold config after moving to another tab on modal for configuring database Nov 1, 2021
@hdl-service hdl-service removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 1, 2021
d-hayashi
d-hayashi approved these changes Nov 2, 2021
View reviewed changes
Copy link
Contributor

@d-hayashi d-hayashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hdl-service hdl-service added the lgtm Indicates that a PR is ready to be merged. label Nov 2, 2021
@hdl-service
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: d-hayashi, WatanabeToshimitsu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [WatanabeToshimitsu,d-hayashi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hdl-service hdl-service merged commit 27403e2 into master Nov 2, 2021
@hdl-service hdl-service deleted the feature/hold-config-after-moving-modal branch November 2, 2021 01:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@d-hayashi d-hayashi d-hayashi approved these changes

Assignees

@d-hayashi d-hayashi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Data Browser] Editing config do not remain when move between tab on modal for configuring database
3 participants
@WatanabeToshimitsu @hdl-service @d-hayashi