Skip to content
This repository has been archived by the owner on Jan 13, 2023. It is now read-only.

Fix to add new clumn to last of input config #211

Merged
merged 1 commit into from
Nov 23, 2021

Conversation

WatanabeToshimitsu
Copy link
Contributor

What?

Fix to add new clumn to last of input config

Why?

To imporove UX

Screenshot or video

Before
InputConfigOrderBug
After
FixInputConfigOrderBug

@hdl-service hdl-service requested a review from yusukefs October 28, 2021 10:59
@hdl-service hdl-service added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 28, 2021
@WatanabeToshimitsu
Copy link
Contributor Author

@yusukefs リマインド

Copy link
Contributor

@yusukefs yusukefs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

すみません遅くなりました!
LGTM

@hdl-service hdl-service added the lgtm Indicates that a PR is ready to be merged. label Nov 23, 2021
@hdl-service
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: WatanabeToshimitsu, yusukefs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [WatanabeToshimitsu,yusukefs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hdl-service hdl-service merged commit 4560cd6 into master Nov 23, 2021
@hdl-service hdl-service deleted the fix/input-fields-config-order branch November 23, 2021 06:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants