This repository has been archived by the owner on Jan 13, 2023. It is now read-only.
Support previewing rosbag files without rosbridge #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: d-hayashi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
hdl-service
added
approved
d-hayashi
changed the title
hdl-service
added
the
do-not-merge/work-in-progress
d-hayashi
changed the title
hdl-service
removed
the
do-not-merge/work-in-progress
WatanabeToshimitsu
suggested changes
Nov 9, 2021
src/components/molecules/FilePreviewer/RosbagPreviewer/index.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add feature to open a rosbag file directly by streaming from api-file-provider.
Why?
Some rosbag files do not require additional ROS-nodes to preview the file.
In that case, streaming data directly from the file improves user experience.
Screenshot or video [Optional]
2021-11-09.16.01.08.mov