Skip to content
This repository has been archived by the owner on Jan 13, 2023. It is now read-only.

Support configuring column data type #223

Merged
merged 4 commits into from
Dec 1, 2021
Merged

Conversation

WatanabeToshimitsu
Copy link
Contributor

@WatanabeToshimitsu WatanabeToshimitsu commented Nov 29, 2021

What?

Support configuring column data type

Why?

To ease to inpu date and number

See also

Resolves dataware-tools/dataware-tools#11

Screenshot or video

SelectColumnDataType

@hdl-service hdl-service requested a review from yusukefs November 29, 2021 12:43
@hdl-service hdl-service added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 29, 2021
@WatanabeToshimitsu WatanabeToshimitsu changed the title Support configuring column data type [WIP] Support configuring column data type Nov 29, 2021
@hdl-service hdl-service added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 29, 2021
@hdl-service hdl-service added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 1, 2021
@WatanabeToshimitsu WatanabeToshimitsu changed the title [WIP] Support configuring column data type Support configuring column data type Dec 1, 2021
@hdl-service hdl-service removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 1, 2021
@WatanabeToshimitsu
Copy link
Contributor Author

@yusukefs WIP 外したのでレビューお願いします!

Copy link
Contributor

@yusukefs yusukefs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hdl-service hdl-service added the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2021
@hdl-service
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: WatanabeToshimitsu, yusukefs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [WatanabeToshimitsu,yusukefs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hdl-service hdl-service merged commit 8d5f4ba into master Dec 1, 2021
@hdl-service hdl-service deleted the feature/select-data-type branch December 1, 2021 06:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[data-browser] 日時,数字などのデータを入力できるようにする
3 participants