This repository has been archived by the owner on Jan 13, 2023. It is now read-only.
Fix build config for symlinking app common #278
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fix build config for symlinking app common
Why?
app-common をシンボリックリンクしたときに,コンポーネントの見た目が違うものになっていて,ヴィジュアルリグレッションテストが正しく行えないから
原因は,app-common の peerDependencies に含まれるライブラリが重複し,MUI の theme が反映されなくなることにあると思われる
Screenshots or videos
app-common が npm でインストールされた場合
app-common/dist を node_modules/@dataware-tools/app-common にシンボリックリンクした場合
修正前
修正後