Skip to content
This repository has been archived by the owner on Jan 13, 2023. It is now read-only.

Bump react-router-dom #311

Merged
merged 3 commits into from
Jan 7, 2022
Merged

Bump react-router-dom #311

merged 3 commits into from
Jan 7, 2022

Conversation

WatanabeToshimitsu
Copy link
Contributor

What?

Bump react-router-dom

Why?

メジャーバージョンのアップデートでAPIが変わったので

See also

https://reactrouter.com/docs/en/v6/upgrading/v5#upgrade-to-react-router-v6

@hdl-service hdl-service added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 28, 2021
@WatanabeToshimitsu
Copy link
Contributor Author

@d-hayashi
リマインド！

@d-hayashi
Copy link
Contributor

Bump系ってどこまでチェックすれば良いですかね？

@WatanabeToshimitsu
Copy link
Contributor Author

@d-hayashi
諸々こっちの方でもチェックしつつやってるので，基本的に軽くレビューしてもらえばいいんですが，一番見て欲しいのは動作面です！
というのも，Bump 系の PR は，メジャーバージョンの更新によって使い方が変わったり，影響範囲が大きい感じの更新を行ったりしたときにレビューをお願いしていることが多いはずなので，動作的なデグレがあり得るからです

これでいうと，ページが遷移するかとか，その時に履歴が溜まってるかとか，そういうのを確認していただけると嬉しいです

理想的には，ドキュメントとか release note/CHANGELOG を見て差分に従えてるかも見てもらえるのが一番なんですが，これはある程度そのライブラリに慣れてないと相当きついと思うので，興味があればで大丈夫です

d-hayashi
d-hayashi approved these changes Jan 7, 2022
View reviewed changes
Copy link
Contributor

@d-hayashi d-hayashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hdl-service hdl-service added the lgtm Indicates that a PR is ready to be merged. label Jan 7, 2022
@hdl-service
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: d-hayashi, WatanabeToshimitsu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [WatanabeToshimitsu,d-hayashi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hdl-service hdl-service merged commit 1a4e94e into master Jan 7, 2022
@hdl-service hdl-service deleted the bump/react-router branch January 7, 2022 10:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@d-hayashi d-hayashi d-hayashi approved these changes

Assignees

@d-hayashi d-hayashi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WatanabeToshimitsu @d-hayashi @hdl-service