Skip to content
This repository has been archived by the owner on Jan 13, 2023. It is now read-only.

Add link to document on DefaultPreviewer #330

Merged

Conversation

yusukefs
Copy link
Contributor

@yusukefs yusukefs commented Jan 6, 2022

What?

DefaultPreviewerに、プレビューでサポートされているファイル拡張子一覧のセクションへのリンクを追加

Why?

あったほうがユーザにとって親切

See also [Optional]

Resolves dataware-tools/dataware-tools#107

Screenshot or video [Optional]

スクリーンショット 2022-01-06 14 28 11

@hdl-service hdl-service added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 6, 2022
Copy link
Contributor

@WatanabeToshimitsu WatanabeToshimitsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
M1 で chrome 動かせてビジュアルリグレッションテスト用の画像更新出来たらマージしてもらってOKです!

@hdl-service hdl-service added the lgtm Indicates that a PR is ready to be merged. label Jan 7, 2022
@hdl-service
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: WatanabeToshimitsu, yusukefs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [WatanabeToshimitsu,yusukefs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hdl-service hdl-service removed the lgtm Indicates that a PR is ready to be merged. label Jan 7, 2022
@hdl-service
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@yusukefs
Copy link
Contributor Author

yusukefs commented Jan 7, 2022

結局なかなかうまくいかなかったので、一旦諦めて手持ちのWindowsマシンで環境作って済ませてしまいました

@yusukefs yusukefs merged commit f26c126 into master Jan 7, 2022
@hdl-service hdl-service deleted the feature/add-link-to-supported-file-types-on-default-previewer branch January 7, 2022 05:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Data browser] Preview supported file extensions should be shown when previewing file is not supported
3 participants